Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

vimPlugins.avante-nvim: 2024-09-30 -> 2024-10-18 #350080

Merged
merged 1 commit into from
Oct 21, 2024

Conversation

ttrei
Copy link
Contributor

@ttrei ttrei commented Oct 20, 2024

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 24.11 Release Notes (or backporting 23.11 and 24.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

Add a 👍 reaction to pull requests you find important.

@ttrei ttrei requested a review from aarnphm October 20, 2024 18:39
@nix-owners nix-owners bot requested a review from figsoda October 20, 2024 18:40
@ofborg ofborg bot added 11.by: package-maintainer This PR was created by the maintainer of the package it changes 10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10 labels Oct 20, 2024
Copy link
Contributor

@khaneliman khaneliman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we can enable the nvimRequireCheck in here now.

# TODO: enable after https://github.com/NixOS/nixpkgs/pull/342240 merged
# nvimRequireCheck = "avante";

@ttrei ttrei force-pushed the update-avante-nvim branch from d67e391 to 7e32c42 Compare October 21, 2024 07:34
@ttrei ttrei requested a review from khaneliman October 21, 2024 07:34
@ofborg ofborg bot requested a review from aarnphm October 21, 2024 08:39
@khaneliman
Copy link
Contributor

nixpkgs-review result

Generated using nixpkgs-review.

Command: nixpkgs-review pr 350080


x86_64-linux

✅ 2 packages built:
  • vimPlugins.avante-nvim
  • vimPluginsUpdater

aarch64-linux

✅ 2 packages built:
  • vimPlugins.avante-nvim
  • vimPluginsUpdater

x86_64-darwin

✅ 2 packages built:
  • vimPlugins.avante-nvim
  • vimPluginsUpdater

aarch64-darwin

✅ 2 packages built:
  • vimPlugins.avante-nvim
  • vimPluginsUpdater

Copy link
Contributor

@khaneliman khaneliman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks

@teto teto merged commit 17fcf9c into NixOS:master Oct 21, 2024
27 of 28 checks passed
@ttrei ttrei deleted the update-avante-nvim branch October 22, 2024 09:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
6.topic: vim 10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10 11.by: package-maintainer This PR was created by the maintainer of the package it changes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants